Remaining code for basic tile compression functionality.

Remaining code for basic tile compression functionality.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[reveman, 2015-07-21 04:26:32]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2015-07-21 04:26:33]

Mostly nits. Maybe split into multiple patches if possible.

https://codereview.chromium.org/1197423003/diff/60001/cc/raster/tile_task_wor...
File cc/raster/tile_task_worker_pool.cc (right):

https://codereview.chromium.org/1197423003/diff/60001/cc/raster/tile_task_wor...
cc/raster/tile_task_worker_pool.cc:171: bool needs_copy =
IsResourceFormatCompressed(format) ||
nit: s/needs_copy/needs_conversion/

The only format that doesn't need conversion is info.colorType(). Instead of
adding a special case for IsResourceFormatCompressed, can we simply get the
matching resource format for info.colorType() and set needs_conversion to true
if it doesn't match |format|?

https://codereview.chromium.org/1197423003/diff/60001/cc/raster/tile_task_wor...
cc/raster/tile_task_worker_pool.cc:204:
TextureCompressor::Create(TextureCompressor::kFormatETC1);
hm, I think we should assume that creating a texture compressor instance is
expensive. can we use a process wide instance?

https://codereview.chromium.org/1197423003/diff/60001/cc/raster/tile_task_wor...
cc/raster/tile_task_worker_pool.cc:206: default:
Please explicitly list all formats here and add a NOTREACHED below instead of a
default case. Makes it easy to see that this code needs to be updated when
adding a new format.

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
cc/resources/resource_provider.cc:1894: // TODO(christiank): Should use
CompressedCopySubTextureCHROMIUM.
Let's fix this TODO before landing this patch.

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
File cc/resources/resource_provider.h (right):

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
cc/resources/resource_provider.h:87: bool use_tile_compression,
s/use_tile_compression/use_compressed_texture_formats/

ResourceProvider doesn't know what a 'tile' is..

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
cc/resources/resource_provider.h:95: ResourceFormat
memory_efficient_texture_format(bool must_be_noncompressed,
Can we avoid must_be_noncompressed param for now and add that later if needed?

https://codereview.chromium.org/1197423003/diff/60001/cc/resources/resource_p...
cc/resources/resource_provider.h:96: bool must_support_alpha) const;
I think this change that adds a "bool alpha" param to this function can land
separately.

https://codereview.chromium.org/1197423003/diff/60001/cc/tiles/tile_manager.cc
File cc/tiles/tile_manager.cc (right):

https://codereview.chromium.org/1197423003/diff/60001/cc/tiles/tile_manager.c...
cc/tiles/tile_manager.cc:972: tile->desired_texture_size().height() % 4 != 0;
Can we instead clamp tile size to multiple of 4 if that's not already done so
that we never have to worry about not being able to use compression because of
tile size?

[christiank, 2015-12-11 10:12:04]

Description was changed from

==========
Remaining code for basic tile compression functionality.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remaining code for basic tile compression functionality.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========