Remaining code for basic tile compression functionality.

cc/raster/tile_task_worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/raster/tile_task_worker_pool.h"
 
 #include <algorithm>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/playback/raster_source.h"
+#include "cc/raster/texture_compressor.h"
 #include "skia/ext/refptr.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkSurface.h"
 
 namespace cc {
 namespace {
 
 class TaskSetFinishedTaskImpl : public TileTask {
  public:
   explicit TaskSetFinishedTaskImpl(
@@ skipping 113 matching lines @@
   }
 
   InsertNodeForTask(graph, raster_task, priority, dependencies);
 }
 
 static bool IsSupportedPlaybackToMemoryFormat(ResourceFormat format) {
   switch (format) {
     case RGBA_4444:
     case RGBA_8888:
     case BGRA_8888:
+    case ETC1:
       return true;
     case ALPHA_8:
     case LUMINANCE_8:
     case RGB_565:
-    case ETC1:
     case RED_8:
       return false;
   }
   NOTREACHED();
   return false;
 }
 
 // static
 void TileTaskWorkerPool::PlaybackToMemory(void* memory,
                                           ResourceFormat format,
                                           const gfx::Size& size,
                                           size_t stride,
                                           const RasterSource* raster_source,
                                           const gfx::Rect& canvas_bitmap_rect,
                                           const gfx::Rect& canvas_playback_rect,
                                           float scale) {
   DCHECK(IsSupportedPlaybackToMemoryFormat(format)) << format;
 
   // Uses kPremul_SkAlphaType since the result is not known to be opaque.
   SkImageInfo info =
       SkImageInfo::MakeN32(size.width(), size.height(), kPremul_SkAlphaType);
-  SkColorType buffer_color_type = ResourceFormatToSkColorType(format);
-  bool needs_copy = buffer_color_type != info.colorType();
+  bool needs_copy = IsResourceFormatCompressed(format) ||

[reveman, 2015/07/21 04:26:33]

nit: s/needs_copy/needs_conversion/

The only format that doesn't need conversion is info.colorType(). Instead of
adding a special case for IsResourceFormatCompressed, can we simply get the
matching resource format for info.colorType() and set needs_conversion to true
if it doesn't match |format|?

+                    ResourceFormatToSkColorType(format) != info.colorType();
 
   // Use unknown pixel geometry to disable LCD text.
   SkSurfaceProps surface_props(0, kUnknown_SkPixelGeometry);
   if (raster_source->CanUseLCDText()) {
     // LegacyFontHost will get LCD text and skia figures out what type to use.
     surface_props = SkSurfaceProps(SkSurfaceProps::kLegacyFontHost_InitType);
   }
 
   if (!stride)
     stride = info.minRowBytes();
   DCHECK_GT(stride, 0u);
 
   if (!needs_copy) {
     skia::RefPtr<SkSurface> surface = skia::AdoptRef(
         SkSurface::NewRasterDirect(info, memory, stride, &surface_props));
     skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
     raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
                                     canvas_playback_rect, scale);
     return;
   }
 
   skia::RefPtr<SkSurface> surface =
       skia::AdoptRef(SkSurface::NewRaster(info, &surface_props));
   skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
   raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
                                   canvas_playback_rect, scale);
 
-  SkImageInfo dst_info =
-      SkImageInfo::Make(info.width(), info.height(), buffer_color_type,
-                        info.alphaType(), info.profileType());
-  // TODO(kaanb): The GL pipeline assumes a 4-byte alignment for the
-  // bitmap data. There will be no need to call SkAlign4 once crbug.com/293728
-  // is fixed.
-  const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes());
-  DCHECK_EQ(0u, dst_row_bytes % 4);
-  bool success = canvas->readPixels(dst_info, memory, dst_row_bytes, 0, 0);
-  DCHECK_EQ(true, success);
+  scoped_ptr<TextureCompressor> texture_compressor;
+  switch (format) {
+    case ETC1:
+      texture_compressor =
+          TextureCompressor::Create(TextureCompressor::kFormatETC1);

[reveman, 2015/07/21 04:26:33]

hm, I think we should assume that creating a texture compressor instance is
expensive. can we use a process wide instance?

+      break;
+    default:

[reveman, 2015/07/21 04:26:33]

Please explicitly list all formats here and add a NOTREACHED below instead of a
default case. Makes it easy to see that this code needs to be updated when
adding a new format.

+      SkImageInfo dst_info = SkImageInfo::Make(
+          info.width(), info.height(), ResourceFormatToSkColorType(format),
+          info.alphaType(), info.profileType());
+      // TODO(kaanb): The GL pipeline assumes a 4-byte alignment for the
+      // bitmap data. There will be no need to call SkAlign4 once
+      // crbug.com/293728 is fixed.
+      const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes());
+      DCHECK_EQ(0u, dst_row_bytes % 4);
+      bool success = canvas->readPixels(dst_info, memory, dst_row_bytes, 0, 0);
+      DCHECK_EQ(true, success);
+      return;
+  }
+
+  texture_compressor->Compress(
+      reinterpret_cast<const uint8_t*>(surface->peekPixels(nullptr, nullptr)),
+      reinterpret_cast<uint8_t*>(memory), size.width(), size.height(),
+      TextureCompressor::kQualityHigh);
 }
 
 }  // namespace cc