Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1197223002: Subzero: Use C++11 member initializers where practical. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use C++11 member initializers where practical. Also change the pattern "foo() {}" into "foo() = default;" for ctors and dtors. Generally avoids initializing unique_ptr<> members to nullptr in a .h file, because that requires knowing the definition of the underlying class which may not be available to all includers. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=eafb56cbab02dbf11071efbc56b4a7098bd40dc7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -234 lines) Patch
M src/IceAssembler.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/IceAssembler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceAssemblerX8632.h View 6 chunks +7 lines, -7 lines 0 comments Download
M src/IceBrowserCompileServer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceBrowserCompileServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/IceCfg.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M src/IceCfgNode.h View 1 chunk +10 lines, -9 lines 0 comments Download
M src/IceCfgNode.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M src/IceClFlagsExtra.h View 2 chunks +10 lines, -12 lines 0 comments Download
M src/IceCompileServer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCompiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceConverter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceDefs.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceELFObjectWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceELFObjectWriter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/IceELFSection.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceFixups.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceGlobalContext.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 6 chunks +6 lines, -8 lines 0 comments Download
M src/IceGlobalInits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceInst.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/IceInst.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceIntrinsics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceLiveness.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/IceOperand.h View 1 10 chunks +28 lines, -33 lines 0 comments Download
M src/IceRegAlloc.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/IceTargetLowering.h View 5 chunks +10 lines, -10 lines 0 comments Download
M src/IceTargetLowering.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 4 chunks +11 lines, -12 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/IceThreading.h View 4 chunks +4 lines, -5 lines 0 comments Download
M src/IceTimerTree.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/IceTimerTree.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceTranslator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTypes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/PNaClTranslator.cpp View 17 chunks +21 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
Sorry for the mind-numbing refactoring CL...
5 years, 6 months ago (2015-06-22 17:21:46 UTC) #2
John
lgtm
5 years, 6 months ago (2015-06-22 17:30:15 UTC) #3
Jim Stichnoth
Rebase
5 years, 6 months ago (2015-06-22 17:35:17 UTC) #4
Jim Stichnoth
5 years, 6 months ago (2015-06-22 17:35:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eafb56cbab02dbf11071efbc56b4a7098bd40dc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698