src/IceGlobalInits.h - Issue 1197223002: Subzero: Use C++11 member initializers where practical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalInits.h

Issue 1197223002: Subzero: Use C++11 member initializers where practical. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalInits.h

diff --git a/src/IceGlobalInits.h b/src/IceGlobalInits.h

index 754f181d510ac47ced3185e384b04c1848ff249f..824f704578812fe112f10c80852d111f4d673f89 100644

--- a/src/IceGlobalInits.h

+++ b/src/IceGlobalInits.h

@@ -54,7 +54,7 @@ public:

void setLinkage(llvm::GlobalValue::LinkageTypes NewLinkage) {

Linkage = NewLinkage;

}

- virtual ~GlobalDeclaration() {}

+ virtual ~GlobalDeclaration() = default;

/// Prints out type of the global declaration.

virtual void dumpType(Ostream &Stream) const = 0;

@@ -142,7 +142,7 @@ public:

RelocInitializerKind

};

InitializerKind getKind() const { return Kind; }

- virtual ~Initializer() {}

+ virtual ~Initializer() = default;

virtual SizeT getNumBytes() const = 0;

virtual void dump(GlobalContext *Ctx, Ostream &Stream) const = 0;

void dump(Ostream &Stream) const {

« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceInst.h » ('j') | no next file with comments »