src/IceDefs.h - Issue 1197223002: Subzero: Use C++11 member initializers where practical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceDefs.h

Issue 1197223002: Subzero: Use C++11 member initializers where practical. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceDefs.h

diff --git a/src/IceDefs.h b/src/IceDefs.h

index 0e8cdfbe39d6117a11e87ecd1c064ebfe44fb478..64e70de9440be3d43324a52991c58e124f57c8fb 100644

--- a/src/IceDefs.h

+++ b/src/IceDefs.h

@@ -201,7 +201,7 @@ class ErrorCode : public std::error_code {

ErrorCode &operator=(const ErrorCode &) = delete;

public:

- ErrorCode() : HasError(false) {}

+ ErrorCode() = default;

void assign(ErrorCodes Code) {

if (!HasError) {

HasError = true;

@@ -211,7 +211,7 @@ public:

void assign(int Code) { assign(static_cast<ErrorCodes>(Code)); }

private:

- bool HasError;

+ bool HasError = false;

};

// Reverse range adaptors written in terms of llvm::make_range().

« no previous file with comments | « src/IceConverter.h ('k') | src/IceELFObjectWriter.h » ('j') | no next file with comments »