Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 11970009: Make the Isolate parameter mandatory in Locker and Unlocker classes. (Closed)

Created:
7 years, 11 months ago by Sven Panne
Modified:
7 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Make the Isolate parameter mandatory in Locker and Unlocker classes. Note that leaving out the Isolate parameter previously had a very special meaning, namely "use the *default* Isolate", i.e. the one magically created at program initialization time. All other API entries use the meaning "current Isolate", which is different in a multi-threaded setting and confusing. Temporarily disabled deprecations until Chrome is ready. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13419

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. Added TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -134 lines) Patch
M include/v8.h View 1 8 chunks +50 lines, -37 lines 0 comments Download
M samples/lineprocessor.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 10 chunks +11 lines, -11 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/isolate.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/isolate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/v8threads.cc View 4 chunks +22 lines, -18 lines 0 comments Download
M test/cctest/cctest.h View 4 chunks +14 lines, -8 lines 0 comments Download
M test/cctest/cctest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 19 chunks +28 lines, -28 lines 0 comments Download
M test/cctest/test-lockers.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-threads.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 11 months ago (2013-01-16 12:30:25 UTC) #1
Michael Starzinger
LGTM (with a nit). https://chromiumcodereview.appspot.com/11970009/diff/1/src/isolate.h File src/isolate.h (right): https://chromiumcodereview.appspot.com/11970009/diff/1/src/isolate.h#newcode1074 src/isolate.h:1074: // to create a Locker ...
7 years, 11 months ago (2013-01-17 10:53:18 UTC) #2
Sven Panne
7 years, 11 months ago (2013-01-18 07:20:04 UTC) #3
Landing...

https://chromiumcodereview.appspot.com/11970009/diff/1/src/isolate.h
File src/isolate.h (right):

https://chromiumcodereview.appspot.com/11970009/diff/1/src/isolate.h#newcode1074
src/isolate.h:1074: // to create a Locker for the first time (the lock itself is
in the isolate).
On 2013/01/17 10:53:18, Michael Starzinger wrote:
> I guess in the long run this method should disappear completely. Can we add a
> TODO about that?

Done.

Powered by Google App Engine
This is Rietveld 408576698