src/d8-debug.cc - Issue 11970009: Make the Isolate parameter mandatory in Locker and Unlocker classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8-debug.cc

Issue 11970009: Make the Isolate parameter mandatory in Locker and Unlocker classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased. Added TODO. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8-debug.cc

diff --git a/src/d8-debug.cc b/src/d8-debug.cc

index de0faa8ae66f295b1e617bb01afc47a2c299fcc0..f044328ae1f2157bb7e12637723c1ddbc11db321 100644

--- a/src/d8-debug.cc

+++ b/src/d8-debug.cc

@@ -273,7 +273,7 @@ RemoteDebuggerEvent* RemoteDebugger::GetEvent() {

void RemoteDebugger::HandleMessageReceived(char* message) {

- Locker lock;

+ Locker lock(v8::Isolate::GetCurrent());

HandleScope scope;

// Print the event details.

@@ -302,7 +302,7 @@ void RemoteDebugger::HandleMessageReceived(char* message) {

void RemoteDebugger::HandleKeyboardCommand(char* command) {

- Locker lock;

+ Locker lock(v8::Isolate::GetCurrent());

HandleScope scope;

// Convert the debugger command to a JSON debugger request.

« no previous file with comments | « src/d8.cc ('k') | src/debug.cc » ('j') | no next file with comments »