Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1196213012: Add minedigger example (Closed)

Created:
5 years, 6 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viktorl
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add minedigger example A very basic minesweeper clone. Currently only tested in linux. BUG=none R=abarth@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/475a02a2b46ffb03820f1569794021dd6acbc20a

Patch Set 1 #

Total comments: 6

Patch Set 2 : review changes (adam) #

Total comments: 6

Patch Set 3 : review (eric) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -0 lines) Patch
A sky/examples/mine_digger/mine_digger.dart View 1 2 1 chunk +366 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
eseidel
Thanks! Attempted to run it locally and hit an exception: E/chromium(27811): Uncaught Error: Class 'Text' ...
5 years, 6 months ago (2015-06-23 01:00:59 UTC) #3
cpu_(ooo_6.6-7.5)
Still not complete as per expectations of a seasoned minesweeper player. The timer is not ...
5 years, 6 months ago (2015-06-23 01:01:53 UTC) #5
abarth-chromium
LGTM This is great. Thanks so much! https://codereview.chromium.org/1196213012/diff/1/sky/examples/mine_digger/mine_digger.dart File sky/examples/mine_digger/mine_digger.dart (right): https://codereview.chromium.org/1196213012/diff/1/sky/examples/mine_digger/mine_digger.dart#newcode7 sky/examples/mine_digger/mine_digger.dart:7: import 'dart:core'; ...
5 years, 6 months ago (2015-06-23 04:05:17 UTC) #6
eseidel
Worked when I ran it just now. I think we should land this and iterate ...
5 years, 6 months ago (2015-06-23 16:25:45 UTC) #8
cpu_(ooo_6.6-7.5)
all changes addressed. thanks!
5 years, 6 months ago (2015-06-23 17:36:54 UTC) #9
eseidel
lgtm Land away! https://codereview.chromium.org/1196213012/diff/20001/sky/examples/mine_digger/mine_digger.dart File sky/examples/mine_digger/mine_digger.dart (right): https://codereview.chromium.org/1196213012/diff/20001/sky/examples/mine_digger/mine_digger.dart#newcode21 sky/examples/mine_digger/mine_digger.dart:21: static final int rows = 9; ...
5 years, 6 months ago (2015-06-23 17:50:12 UTC) #11
cpu_(ooo_6.6-7.5)
I converted all vars to actual types and use consts instead of finals. https://codereview.chromium.org/1196213012/diff/20001/sky/examples/mine_digger/mine_digger.dart File ...
5 years, 6 months ago (2015-06-23 18:19:10 UTC) #12
cpu_(ooo_6.6-7.5)
5 years, 6 months ago (2015-06-23 18:20:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
475a02a2b46ffb03820f1569794021dd6acbc20a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698