Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup: Do not check pointers before deleting them, part 2. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/21bf242a31eff79f754c5e9c3b41c52e33483bb0

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 17

Patch Set 3 : rebase #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -101 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 5 chunks +5 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 3 chunks +7 lines, -21 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 2 3 2 chunks +2 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 5 months ago (2015-07-16 17:11:03 UTC) #2
Tom Sepez
We're gonna conflict against my previous cleanup CL. Who wants to go first? LGTM % ...
5 years, 5 months ago (2015-07-16 17:22:45 UTC) #3
Lei Zhang
Probably easier if you go first.
5 years, 5 months ago (2015-07-16 17:27:34 UTC) #4
Lei Zhang
https://codereview.chromium.org/1195363002/diff/20001/core/src/fxge/apple/fx_mac_imp.cpp File core/src/fxge/apple/fx_mac_imp.cpp (right): https://codereview.chromium.org/1195363002/diff/20001/core/src/fxge/apple/fx_mac_imp.cpp#newcode103 core/src/fxge/apple/fx_mac_imp.cpp:103: delete (CApplePlatform *) m_pPlatformData; On 2015/07/16 17:22:44, Tom Sepez ...
5 years, 5 months ago (2015-07-16 21:20:48 UTC) #6
Lei Zhang
5 years, 5 months ago (2015-07-17 01:28:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) manually as
21bf242a31eff79f754c5e9c3b41c52e33483bb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698