fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index f21819ac17424cc80bb88dbf6899769bb756e6d0..2343eb3a4354a2289f3ec1f56f1772d3c62692c4 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -65,8 +65,7 @@ void CJS_RuntimeFactory::Release()

void CJS_RuntimeFactory::DeleteJSRuntime(IFXJS_Runtime* pRuntime)

{

- if(pRuntime)

- delete (CJS_Runtime*)pRuntime;

+ delete (CJS_Runtime*)pRuntime;

}

CJS_GlobalData* CJS_RuntimeFactory::NewGlobalData(CPDFDoc_Environment* pApp)

« no previous file with comments | « fpdfsdk/src/javascript/JS_Context.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_FontMap.cpp » ('j') | no next file with comments »