core/src/fxge/apple/fx_mac_imp.cpp - Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/apple/fx_mac_imp.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #include "../../../include/fxge/fx_ge.h"	7 #include "../../../include/fxge/fx_ge.h"

8 #include "apple_int.h"	8 #include "apple_int.h"

9 #if _FX_OS_ == _FX_MACOSX_	9 #if _FX_OS_ == _FX_MACOSX_

10 static const struct {	10 static const struct {

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 pInfo->AddPath("/System/Library/Fonts");	93 pInfo->AddPath("/System/Library/Fonts");

94 return pInfo;	94 return pInfo;

95 }	95 }

96 void CFX_GEModule::InitPlatform()	96 void CFX_GEModule::InitPlatform()

97 {	97 {

98 m_pPlatformData = new CApplePlatform;	98 m_pPlatformData = new CApplePlatform;

99 m_pFontMgr->SetSystemFontInfo(IFX_SystemFontInfo::CreateDefault());	99 m_pFontMgr->SetSystemFontInfo(IFX_SystemFontInfo::CreateDefault());

100 }	100 }

101 void CFX_GEModule::DestroyPlatform()	101 void CFX_GEModule::DestroyPlatform()

102 {	102 {

103 if (m_pPlatformData) {	103 delete (CApplePlatform *) m_pPlatformData;
	Tom Sepez 2015/07/16 17:22:44 nit: no space before , no space after ) nit: no space before , no space after ) Lei Zhang 2015/07/16 21:20:48 Done. Show quoted text On 2015/07/16 17:22:44, Tom Sepez wrote: > nit: no space before *, no space after ) Done.
104 delete (CApplePlatform *) m_pPlatformData;

105 }

106 m_pPlatformData = NULL;	104 m_pPlatformData = NULL;

107 }	105 }

108 #endif	106 #endif

OLD	NEW

« no previous file with comments | « core/src/fxge/android/fpf_skiamodule.cpp ('k') | core/src/fxge/win32/fx_win32_device.cpp » ('j') | fpdfsdk/src/formfiller/FFL_ComboBox.cpp » ('J')