Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | fpdfsdk/src/formfiller/FFL_ListBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/formfiller/FormFiller.h" 7 #include "../../include/formfiller/FormFiller.h"
8 #include "../../include/formfiller/FFL_FormFiller.h" 8 #include "../../include/formfiller/FFL_FormFiller.h"
9 #include "../../include/formfiller/FFL_IFormFiller.h" 9 #include "../../include/formfiller/FFL_IFormFiller.h"
10 #include "../../include/formfiller/FFL_CBA_Fontmap.h" 10 #include "../../include/formfiller/FFL_CBA_Fontmap.h"
11 #include "../../include/formfiller/FFL_ComboBox.h" 11 #include "../../include/formfiller/FFL_ComboBox.h"
12 12
13 13
14 /* ------------------------------- CFFL_ComboBox ------------------------------- */ 14 /* ------------------------------- CFFL_ComboBox ------------------------------- */
15 15
16 CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot) : 16 CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot) :
17 CFFL_FormFiller(pApp, pAnnot), m_pFontMap( NULL ) 17 CFFL_FormFiller(pApp, pAnnot), m_pFontMap( NULL )
18 { 18 {
19 m_State.nIndex = 0; 19 m_State.nIndex = 0;
20 m_State.nStart = 0; 20 m_State.nStart = 0;
21 m_State.nEnd = 0; 21 m_State.nEnd = 0;
22 } 22 }
23 23
24 CFFL_ComboBox::~CFFL_ComboBox() 24 CFFL_ComboBox::~CFFL_ComboBox()
25 { 25 {
26 » if (m_pFontMap) 26 delete m_pFontMap;
27 » {
28 » » delete m_pFontMap;
29 » » m_pFontMap = NULL;
30 » }
31 } 27 }
32 28
33 PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam() 29 PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam()
34 { 30 {
35 PWL_CREATEPARAM cp = CFFL_FormFiller::GetCreateParam(); 31 PWL_CREATEPARAM cp = CFFL_FormFiller::GetCreateParam();
36 32
37 ASSERT(m_pWidget != NULL); 33 ASSERT(m_pWidget != NULL);
38 34
39 int nFlags = m_pWidget->GetFieldFlags(); 35 int nFlags = m_pWidget->GetFieldFlags();
40 36
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 if (CPDF_FormField * pFormField = m_pWidget->GetFormField()) 393 if (CPDF_FormField * pFormField = m_pWidget->GetFormField())
398 { 394 {
399 swRet = pFormField->GetOptionValue(nExport); 395 swRet = pFormField->GetOptionValue(nExport);
400 if (swRet.IsEmpty()) 396 if (swRet.IsEmpty())
401 swRet = pFormField->GetOptionLabel(nExport); 397 swRet = pFormField->GetOptionLabel(nExport);
402 } 398 }
403 } 399 }
404 400
405 return swRet; 401 return swRet;
406 } 402 }
OLDNEW
« no previous file with comments | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | fpdfsdk/src/formfiller/FFL_ListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698