Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1194943004: Get rid of JSArray::Expand and friends (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of JSArray::Expand and friends BUG= Committed: https://crrev.com/57a3810280390a2d9599b8c41f831eac82ab57c4 Cr-Commit-Position: refs/heads/master@{#29180}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -75 lines) Patch
M src/ast.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/elements.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/elements.cc View 5 chunks +7 lines, -23 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-19 17:15:31 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-22 10:38:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194943004/20001
5 years, 6 months ago (2015-06-22 10:42:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 10:44:21 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 10:44:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57a3810280390a2d9599b8c41f831eac82ab57c4
Cr-Commit-Position: refs/heads/master@{#29180}

Powered by Google App Engine
This is Rietveld 408576698