Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: src/json-stringifier.h

Issue 1194943004: Get rid of JSArray::Expand and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/elements.cc ('k') | src/jsregexp.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_JSON_STRINGIFIER_H_ 5 #ifndef V8_JSON_STRINGIFIER_H_
6 #define V8_JSON_STRINGIFIER_H_ 6 #define V8_JSON_STRINGIFIER_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 for (int i = 0; i < length; i++) { 273 for (int i = 0; i < length; i++) {
274 if (elements->get(i) == *object) { 274 if (elements->get(i) == *object) {
275 AllowHeapAllocation allow_to_return_error; 275 AllowHeapAllocation allow_to_return_error;
276 Handle<Object> error = 276 Handle<Object> error =
277 factory()->NewTypeError(MessageTemplate::kCircularStructure); 277 factory()->NewTypeError(MessageTemplate::kCircularStructure);
278 isolate_->Throw(*error); 278 isolate_->Throw(*error);
279 return EXCEPTION; 279 return EXCEPTION;
280 } 280 }
281 } 281 }
282 } 282 }
283 JSArray::EnsureSize(stack_, length + 1); 283 JSArray::SetLength(stack_, length + 1);
284 FixedArray::cast(stack_->elements())->set(length, *object); 284 FixedArray::cast(stack_->elements())->set(length, *object);
285 stack_->set_length(Smi::FromInt(length + 1));
286 return SUCCESS; 285 return SUCCESS;
287 } 286 }
288 287
289 288
290 void BasicJsonStringifier::StackPop() { 289 void BasicJsonStringifier::StackPop() {
291 int length = Smi::cast(stack_->length())->value(); 290 int length = Smi::cast(stack_->length())->value();
292 stack_->set_length(Smi::FromInt(length - 1)); 291 stack_->set_length(Smi::FromInt(length - 1));
293 } 292 }
294 293
295 294
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 SerializeString_<uint8_t, uc16>(object); 677 SerializeString_<uint8_t, uc16>(object);
679 } else { 678 } else {
680 SerializeString_<uc16, uc16>(object); 679 SerializeString_<uc16, uc16>(object);
681 } 680 }
682 } 681 }
683 } 682 }
684 683
685 } } // namespace v8::internal 684 } } // namespace v8::internal
686 685
687 #endif // V8_JSON_STRINGIFIER_H_ 686 #endif // V8_JSON_STRINGIFIER_H_
OLDNEW
« no previous file with comments | « src/elements.cc ('k') | src/jsregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698