src/jsregexp.cc - Issue 1194943004: Get rid of JSArray::Expand and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 1194943004: Get rid of JSArray::Expand and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/jsregexp.cc

diff --git a/src/jsregexp.cc b/src/jsregexp.cc

index 6de8596071544929e7300a8c05c8f1069498b48c..be6e2a92027b5cf56bb9628036b2fb13f8ead5b3 100644

--- a/src/jsregexp.cc

+++ b/src/jsregexp.cc

@@ -624,8 +624,8 @@ Handle<JSArray> RegExpImpl::SetLastMatchInfo(Handle<JSArray> last_match_info,

int32_t* match) {

DCHECK(last_match_info->HasFastObjectElements());

int capture_register_count = (capture_count + 1) * 2;

- JSArray::EnsureSize(last_match_info,

- capture_register_count + kLastMatchOverhead);

+ JSArray::SetLength(last_match_info,

+ capture_register_count + kLastMatchOverhead);

DisallowHeapAllocation no_allocation;

FixedArray* array = FixedArray::cast(last_match_info->elements());

if (match != NULL) {

« no previous file with comments | « src/json-stringifier.h ('k') | src/objects.h » ('j') | no next file with comments »