Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/ast.cc

Issue 1194943004: Get rid of JSArray::Expand and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/elements.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast.h" 5 #include "src/ast.h"
6 6
7 #include <cmath> // For isfinite. 7 #include <cmath> // For isfinite.
8 #include "src/builtins.h" 8 #include "src/builtins.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/contexts.h" 10 #include "src/contexts.h"
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 has_elements_ = elements > 0; 514 has_elements_ = elements > 0;
515 set_is_simple(is_simple); 515 set_is_simple(is_simple);
516 set_depth(depth_acc); 516 set_depth(depth_acc);
517 } 517 }
518 518
519 519
520 void ArrayLiteral::BuildConstantElements(Isolate* isolate) { 520 void ArrayLiteral::BuildConstantElements(Isolate* isolate) {
521 if (!constant_elements_.is_null()) return; 521 if (!constant_elements_.is_null()) return;
522 522
523 // Allocate a fixed array to hold all the object literals. 523 // Allocate a fixed array to hold all the object literals.
524 Handle<JSArray> array = 524 Handle<JSArray> array = isolate->factory()->NewJSArray(
525 isolate->factory()->NewJSArray(0, FAST_HOLEY_SMI_ELEMENTS); 525 FAST_HOLEY_SMI_ELEMENTS, values()->length(), values()->length(),
526 JSArray::Expand(array, values()->length()); 526 Strength::WEAK, INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);
527 527
528 // Fill in the literals. 528 // Fill in the literals.
529 bool is_simple = true; 529 bool is_simple = true;
530 int depth_acc = 1; 530 int depth_acc = 1;
531 bool is_holey = false; 531 bool is_holey = false;
532 int array_index = 0; 532 int array_index = 0;
533 for (int n = values()->length(); array_index < n; array_index++) { 533 for (int n = values()->length(); array_index < n; array_index++) {
534 Expression* element = values()->at(array_index); 534 Expression* element = values()->at(array_index);
535 if (element->IsSpread()) break; 535 if (element->IsSpread()) break;
536 MaterializedLiteral* m_literal = element->AsMaterializedLiteral(); 536 MaterializedLiteral* m_literal = element->AsMaterializedLiteral();
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 bool Literal::Match(void* literal1, void* literal2) { 1157 bool Literal::Match(void* literal1, void* literal2) {
1158 const AstValue* x = static_cast<Literal*>(literal1)->raw_value(); 1158 const AstValue* x = static_cast<Literal*>(literal1)->raw_value();
1159 const AstValue* y = static_cast<Literal*>(literal2)->raw_value(); 1159 const AstValue* y = static_cast<Literal*>(literal2)->raw_value();
1160 return (x->IsString() && y->IsString() && x->AsString() == y->AsString()) || 1160 return (x->IsString() && y->IsString() && x->AsString() == y->AsString()) ||
1161 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber()); 1161 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber());
1162 } 1162 }
1163 1163
1164 1164
1165 } // namespace internal 1165 } // namespace internal
1166 } // namespace v8 1166 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/elements.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698