Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rely on the map being a dictionary map rather than not having a backpointer BUG=chromium:500173 LOG=n Committed: https://crrev.com/72cdb99346d39a01536c7a2cc373ec250b01151e Cr-Commit-Position: refs/heads/master@{#29074}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Don't cache dictionary changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/lookup.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-500173.js View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
PTAL
5 years, 6 months ago (2015-06-17 09:02:48 UTC) #2
Jakob Kummerow
LGTM. How about checking in the repro as a test?
5 years, 6 months ago (2015-06-17 09:03:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194513003/20001
5 years, 6 months ago (2015-06-17 09:10:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1390)
5 years, 6 months ago (2015-06-17 09:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194513003/40001
5 years, 6 months ago (2015-06-17 09:44:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-17 10:13:54 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 10:14:08 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/72cdb99346d39a01536c7a2cc373ec250b01151e
Cr-Commit-Position: refs/heads/master@{#29074}

Powered by Google App Engine
This is Rietveld 408576698