src/lookup.h - Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't cache dictionary changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index c7a4a36e37b6d80e94c8b0932e1828e7fda1268b..c2b98070c04c52b2b9cdcd913b971354cabe7b10 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -207,7 +207,8 @@ class LookupIterator final BASE_EMBEDDED {

bool IsCacheableTransition() {

if (state_ != TRANSITION) return false;

return transition_->IsPropertyCell() ||

- transition_map()->GetBackPointer()->IsMap();

+ (!transition_map()->is_dictionary_map() &&

+ transition_map()->GetBackPointer()->IsMap());

}

void ApplyTransitionToDataProperty();

void ReconfigureDataProperty(Handle<Object> value,

« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »