Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: src/lookup.cc

Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Don't cache dictionary changes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.h ('k') | test/mjsunit/regress/regress-500173.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 state_ = TRANSITION; 229 state_ = TRANSITION;
230 transition_ = transition; 230 transition_ = transition;
231 231
232 if (receiver->IsGlobalObject()) { 232 if (receiver->IsGlobalObject()) {
233 // Install a property cell. 233 // Install a property cell.
234 InternalizeName(); 234 InternalizeName();
235 auto cell = GlobalObject::EnsurePropertyCell( 235 auto cell = GlobalObject::EnsurePropertyCell(
236 Handle<GlobalObject>::cast(receiver), name()); 236 Handle<GlobalObject>::cast(receiver), name());
237 DCHECK(cell->value()->IsTheHole()); 237 DCHECK(cell->value()->IsTheHole());
238 transition_ = cell; 238 transition_ = cell;
239 } else if (transition->GetBackPointer()->IsMap()) { 239 } else if (!transition->is_dictionary_map()) {
240 property_details_ = transition->GetLastDescriptorDetails(); 240 property_details_ = transition->GetLastDescriptorDetails();
241 has_property_ = true; 241 has_property_ = true;
242 } 242 }
243 } 243 }
244 244
245 245
246 void LookupIterator::ApplyTransitionToDataProperty() { 246 void LookupIterator::ApplyTransitionToDataProperty() {
247 DCHECK_EQ(TRANSITION, state_); 247 DCHECK_EQ(TRANSITION, state_);
248 248
249 Handle<JSObject> receiver = GetStoreTarget(); 249 Handle<JSObject> receiver = GetStoreTarget();
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 case InterceptorState::kSkipNonMasking: 503 case InterceptorState::kSkipNonMasking:
504 return true; 504 return true;
505 case InterceptorState::kProcessNonMasking: 505 case InterceptorState::kProcessNonMasking:
506 return false; 506 return false;
507 } 507 }
508 } 508 }
509 return interceptor_state_ == InterceptorState::kProcessNonMasking; 509 return interceptor_state_ == InterceptorState::kProcessNonMasking;
510 } 510 }
511 } // namespace internal 511 } // namespace internal
512 } // namespace v8 512 } // namespace v8
OLDNEW
« no previous file with comments | « src/lookup.h ('k') | test/mjsunit/regress/regress-500173.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698