src/lookup.cc - Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 1194513003: Rely on the map being a dictionary map rather than not having a backpointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't cache dictionary changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 6a26663b44f87380dfaf9efb5ed16b57467e35ca..b91ad4c9f4bb9ec1b12db7e548bfac0fe27e2fc0 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -236,7 +236,7 @@ void LookupIterator::PrepareTransitionToDataProperty(

Handle<GlobalObject>::cast(receiver), name());

DCHECK(cell->value()->IsTheHole());

transition_ = cell;

- } else if (transition->GetBackPointer()->IsMap()) {

+ } else if (!transition->is_dictionary_map()) {

property_details_ = transition->GetLastDescriptorDetails();

has_property_ = true;

}

« no previous file with comments | « src/lookup.h ('k') | test/mjsunit/regress/regress-500173.js » ('j') | no next file with comments »