Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1192453002: Add build rules to enable language-based split apks on Android (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@load-from-apk-pak
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add build rules to enable language-based split apks on Android BUG=490285 Committed: https://crrev.com/c89cfe476f4d1f9bae23e6980a12a379fbd00da4 Cr-Commit-Position: refs/heads/master@{#336001}

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -83 lines) Patch
M build/android/finalize_splits_action.gypi View 1 2 3 chunks +12 lines, -8 lines 0 comments Download
M build/android/gyp/finalize_splits.py View 2 chunks +11 lines, -3 lines 0 comments Download
M build/android/gyp/locale_pak_resources.py View 1 2 chunks +53 lines, -31 lines 0 comments Download
M build/android/gyp/package_resources.py View 1 2 4 chunks +30 lines, -13 lines 0 comments Download
M build/android/package_resources_action.gypi View 1 2 2 chunks +14 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 5 chunks +51 lines, -22 lines 0 comments Download
M build/config/android/rules.gni View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 4 chunks +13 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
agrieve
5 years, 6 months ago (2015-06-16 18:42:14 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-19 22:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192453002/60001
5 years, 6 months ago (2015-06-24 19:30:22 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-24 21:04:05 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 21:04:58 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c89cfe476f4d1f9bae23e6980a12a379fbd00da4
Cr-Commit-Position: refs/heads/master@{#336001}

Powered by Google App Engine
This is Rietveld 408576698