Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: build/android/finalize_splits_action.gypi

Issue 1192453002: Add build rules to enable language-based split apks on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk-pak
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/finalize_splits.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/finalize_splits_action.gypi
diff --git a/build/android/finalize_splits_action.gypi b/build/android/finalize_splits_action.gypi
index 4472d5a8a968b80f2c0f0f30391ce199144518e9..566cd5033d9872da5cd3e297fc4161e5e92feb0e 100644
--- a/build/android/finalize_splits_action.gypi
+++ b/build/android/finalize_splits_action.gypi
@@ -18,7 +18,7 @@
'keystore_password%': 'chromium',
'zipalign_path%': '<(android_sdk_tools)/zipalign',
'density_splits%': 0,
- 'language_splits%': 0,
+ 'language_splits%': [],
'resource_packaged_apk_name': '<(apk_name)-resources.ap_',
'resource_packaged_apk_path': '<(intermediate_dir)/<(resource_packaged_apk_name)',
'base_output_path': '<(PRODUCT_DIR)/apks/<(apk_name)',
@@ -42,11 +42,11 @@
['density_splits == 1', {
'message': 'Signing/aligning <(_target_name) density splits',
'inputs': [
- '<(resource_packaged_apk_path)-hdpi',
- '<(resource_packaged_apk_path)-xhdpi',
- '<(resource_packaged_apk_path)-xxhdpi',
- '<(resource_packaged_apk_path)-xxxhdpi',
- '<(resource_packaged_apk_path)-tvdpi',
+ '<(resource_packaged_apk_path)_hdpi',
+ '<(resource_packaged_apk_path)_xhdpi',
+ '<(resource_packaged_apk_path)_xxhdpi',
+ '<(resource_packaged_apk_path)_xxxhdpi',
+ '<(resource_packaged_apk_path)_tvdpi',
],
'outputs': [
'<(base_output_path)-density-hdpi.apk',
@@ -59,12 +59,16 @@
'--densities=hdpi,xhdpi,xxhdpi,xxxhdpi,tvdpi',
],
}],
- # TODO(agrieve): Implement language splits
- ['language_splits == 1', {
+ ['language_splits != 1', {
'message': 'Signing/aligning <(_target_name) language splits',
'inputs': [
+ "<!@(python <(DEPTH)/build/apply_locales.py '<(resource_packaged_apk_path)_ZZLOCALE' <(language_splits))",
],
'outputs': [
+ "<!@(python <(DEPTH)/build/apply_locales.py '<(base_output_path)-lang-ZZLOCALE.apk' <(language_splits))",
+ ],
+ 'action': [
+ '--languages=<(language_splits)',
],
}],
],
« no previous file with comments | « no previous file | build/android/gyp/finalize_splits.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698