Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3389)

Unified Diff: build/android/gyp/finalize_splits.py

Issue 1192453002: Add build rules to enable language-based split apks on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk-pak
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/finalize_splits_action.gypi ('k') | build/android/gyp/locale_pak_resources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/finalize_splits.py
diff --git a/build/android/gyp/finalize_splits.py b/build/android/gyp/finalize_splits.py
index 97a65fa9204f898bb7f93babf845ff86e7cdf77d..a6796bbe4f4dd61c221f797fde9db981ad3c77eb 100755
--- a/build/android/gyp/finalize_splits.py
+++ b/build/android/gyp/finalize_splits.py
@@ -12,6 +12,7 @@ import optparse
import sys
import finalize_apk
+from util import build_utils
def main():
parser = optparse.OptionParser()
@@ -25,20 +26,27 @@ def main():
parser.add_option('--key-name', help='Keystore name')
parser.add_option('--densities',
help='Comma separated list of densities finalize.')
+ parser.add_option('--languages',
+ help='GYP list of language splits to finalize.')
options, _ = parser.parse_args()
options.load_library_from_zip = 0
if options.densities:
for density in options.densities.split(','):
- options.unsigned_apk_path = ("%s-%s" %
+ options.unsigned_apk_path = ("%s_%s" %
(options.resource_packaged_apk_path, density))
options.final_apk_path = ("%s-density-%s.apk" %
(options.base_output_path, density))
finalize_apk.FinalizeApk(options)
- else:
- raise Exception('Language splits not yet implemented')
+ if options.languages:
+ for lang in build_utils.ParseGypList(options.languages):
+ options.unsigned_apk_path = ("%s_%s" %
+ (options.resource_packaged_apk_path, lang))
+ options.final_apk_path = ("%s-lang-%s.apk" %
+ (options.base_output_path, lang))
+ finalize_apk.FinalizeApk(options)
if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « build/android/finalize_splits_action.gypi ('k') | build/android/gyp/locale_pak_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698