Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 1181733004: Do not require explicit initialization of ResourceExtractor (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, erikwright+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split-lang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not require explicit initialization of ResourceExtractor It's used only for locale pack files now, so shouldn't require so much attention. This also removes the extraction args from ComponentsBrowserTestsApplication.java, which don't appear to be necessary BUG= Committed: https://crrev.com/5f042d748484efcdac252f44469cb764c4decd3e Cr-Commit-Position: refs/heads/master@{#336020}

Patch Set 1 #

Patch Set 2 : delete setExtractAllPaksAndV8SnapshotForTesting #

Patch Set 3 : Delete TODO (it's now done) #

Total comments: 4

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Messages

Total messages: 18 (4 generated)
agrieve
jaekyun@chromium.org: Please review changes in components/ gunsch@chromium.org: Please review changes in chromecast/ yfriedman@chromium.org: Please review ...
5 years, 6 months ago (2015-06-17 15:32:27 UTC) #2
gunsch
chromecast lgtm
5 years, 6 months ago (2015-06-17 15:58:49 UTC) #3
agrieve
5 years, 6 months ago (2015-06-17 17:33:04 UTC) #4
agrieve
torne@chromium.org: Please review changes in
5 years, 6 months ago (2015-06-17 17:33:26 UTC) #6
Yaron
https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode239 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:239: PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks"); If we haven't extracted any paks, why ...
5 years, 6 months ago (2015-06-17 19:09:54 UTC) #7
agrieve
https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode239 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:239: PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks"); On 2015/06/17 19:09:54, Yaron wrote: > If ...
5 years, 6 months ago (2015-06-17 19:23:12 UTC) #8
Yaron
https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode239 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:239: PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks"); On 2015/06/17 19:23:12, agrieve wrote: > On ...
5 years, 6 months ago (2015-06-17 20:07:48 UTC) #9
agrieve
https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/1181733004/diff/40001/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode239 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:239: PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks"); On 2015/06/17 20:07:48, Yaron wrote: > On ...
5 years, 6 months ago (2015-06-17 20:16:29 UTC) #10
Jaekyun Seok (inactive)
lgtm for components/
5 years, 6 months ago (2015-06-17 21:16:49 UTC) #11
Torne
android_webview LGTM
5 years, 6 months ago (2015-06-18 16:30:10 UTC) #12
Yaron
On 2015/06/18 16:30:10, Torne wrote: > android_webview LGTM lgtm
5 years, 6 months ago (2015-06-18 17:20:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181733004/80001
5 years, 6 months ago (2015-06-24 21:26:59 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-24 22:57:27 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 22:58:37 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5f042d748484efcdac252f44469cb764c4decd3e
Cr-Commit-Position: refs/heads/master@{#336020}

Powered by Google App Engine
This is Rietveld 408576698