Componentize AutocompleteController and its supporting cast

Componentize AutocompleteController and its supporting cast

No changes are required.

BUG=371538
TBR=thakis

Committed: https://crrev.com/a08236ee11f700f1c9321672d66e6f3cf8dd7d6b
Cr-Commit-Position: refs/heads/master@{#336540}

[blundell, 2015-06-19 14:30:43]

blundell@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-06-19 18:55:20]

LGTM

[blundell, 2015-06-22 13:01:02]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-06-22 13:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1191373002/#ps40001
(title: "Rebase")

[blundell, 2015-06-22 13:01:05]

The CQ bit was unchecked by blundell@chromium.org

[blundell, 2015-06-22 13:01:10]

The CQ bit was unchecked by blundell@chromium.org

[blundell, 2015-06-22 13:02:31]

blundell@chromium.org changed reviewers:
+ thakis@chromium.org

[blundell, 2015-06-22 13:03:04]

TBR=thakis for include path changes in //chrome outside of
//chrome/browser/autocomplete and //chrome/browser/ui/omnibox

[blundell, 2015-06-22 13:03:10]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-06-22 13:03:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191373002/40001

[commit-bot: I haz the power, 2015-06-22 13:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 13:20:53]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[blundell, 2015-06-22 15:51:14]

cc sdefresne@

[blundell, 2015-06-23 06:02:59]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-06-23 06:03:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1191373002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-23 06:03:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191373002/60001

[commit-bot: I haz the power, 2015-06-23 06:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 06:21:00]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Nico, 2015-06-23 16:57:07]

etc

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
File chrome/browser/autocomplete/autocomplete_provider_unittest.cc (right):

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
chrome/browser/autocomplete/autocomplete_provider_unittest.cc:2: // Use of this
source code is governed by a BSD-style license that can be
The test should probably move to components too? It seems weird to have the
_unittest.cc file here but move the rest of the code.

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
File chrome/browser/autocomplete/builtin_provider_unittest.cc (right):

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
chrome/browser/autocomplete/builtin_provider_unittest.cc:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
Likewise

[blundell, 2015-06-24 05:37:54]

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
File chrome/browser/autocomplete/autocomplete_provider_unittest.cc (right):

https://codereview.chromium.org/1191373002/diff/60001/chrome/browser/autocomp...
chrome/browser/autocomplete/autocomplete_provider_unittest.cc:2: // Use of this
source code is governed by a BSD-style license that can be
On 2015/06/23 16:57:07, Nico wrote:
> The test should probably move to components too? It seems weird to have the
> _unittest.cc file here but move the rest of the code.

Indeed. I always componentize in two stages: first, production code; second,
unittests. I've found that this enables a nice separation of concerns and I can
proceed much faster than if I try to clean the dependencies of both the
production code and the tests all at once.

This CL is the last of the production code componentization, and then I'm going
to componentize the unittests.

[Nico, 2015-06-24 05:46:33]

lgtm then

(your username seems untrue)

[blundell, 2015-06-24 05:55:22]

On 2015/06/24 05:46:33, Nico wrote:
> lgtm then
> 
> (your username seems untrue)

(it is true; i'm not in the office)

[Nico, 2015-06-24 06:05:07]

On Jun 23, 2015 10:55 PM, <blundell@chromium.org> wrote:
>
> On 2015/06/24 05:46:33, Nico wrote:
>>
>> lgtm then
>
>
>> (your username seems untrue)
>
>
> (it is true; i'm not in the office)

(but you're not blundell, not truly, not with all your heart)

>
> https://codereview.chromium.org/1191373002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blundell, 2015-06-29 07:41:43]

On 2015/06/24 06:05:07, Nico wrote:
> On Jun 23, 2015 10:55 PM, <mailto:blundell@chromium.org> wrote:
> >
> > On 2015/06/24 05:46:33, Nico wrote:
> >>
> >> lgtm then
> >
> >
> >> (your username seems untrue)
> >
> >
> > (it is true; i'm not in the office)
> 
> (but you're not blundell, not truly, not with all your heart)

(I actually had thought about changing my username to "not blundell, not truly,
not with all my heart (OOO until June 29)" but it seemed like a mouthful).

> 
> >
> > https://codereview.chromium.org/1191373002/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[blundell, 2015-06-29 07:44:51]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-06-29 07:44:52]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1191373002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-29 07:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191373002/80001

[commit-bot: I haz the power, 2015-06-29 09:44:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-29 09:45:42]

Patchset 5 (id:??) landed as
https://crrev.com/a08236ee11f700f1c9321672d66e6f3cf8dd7d6b
Cr-Commit-Position: refs/heads/master@{#336540}