chrome/browser/ui/omnibox/omnibox_controller.cc - Issue 1191373002: Componentize AutocompleteController and its supporting cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_controller.cc

Issue 1191373002: Componentize AutocompleteController and its supporting cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prep_builtin_provider_for_c14n

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/omnibox/omnibox_controller.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_controller.cc b/chrome/browser/ui/omnibox/omnibox_controller.cc

index d90c0f7bbda2a8e3643a12688074c0e4e729d330..0d6e24a9b3e8df7a6fcb3219d54c908e492affa3 100644

--- a/chrome/browser/ui/omnibox/omnibox_controller.cc

+++ b/chrome/browser/ui/omnibox/omnibox_controller.cc

@@ -5,7 +5,6 @@

#include "chrome/browser/ui/omnibox/omnibox_controller.h"

#include "base/metrics/histogram.h"

-#include "chrome/browser/autocomplete/autocomplete_classifier.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"

#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service_factory.h"

#include "chrome/browser/net/predictor.h"

@@ -22,6 +21,7 @@

#include "chrome/browser/ui/omnibox/omnibox_popup_model.h"

#include "chrome/browser/ui/omnibox/omnibox_popup_view.h"

#include "chrome/common/instant_types.h"

+#include "components/omnibox/autocomplete_classifier.h"

#include "components/omnibox/autocomplete_match.h"

#include "components/omnibox/search_provider.h"

#include "components/search/search.h"

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_controller.h ('k') | chrome/browser/ui/omnibox/omnibox_controller_unittest.cc » ('j') | no next file with comments »