Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1219653002: Componentize ScoredHistoryMatch unittest (Closed)

Created:
5 years, 5 months ago by blundell
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@componentize_autocomplete_controller
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize ScoredHistoryMatch unittest No changes required. BUG=371538 Committed: https://crrev.com/6ddaaa2bcc9f49df17c5f6dfe84c2d28cc9a5e15 Cr-Commit-Position: refs/heads/master@{#336752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -493 lines) Patch
D chrome/browser/autocomplete/scored_history_match_unittest.cc View 1 chunk +0 lines, -492 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + components/omnibox/scored_history_match_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
blundell
5 years, 5 months ago (2015-06-29 08:55:47 UTC) #2
Peter Kasting
LGTM
5 years, 5 months ago (2015-06-29 21:29:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219653002/1
5 years, 5 months ago (2015-06-30 08:40:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 09:29:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 09:29:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ddaaa2bcc9f49df17c5f6dfe84c2d28cc9a5e15
Cr-Commit-Position: refs/heads/master@{#336752}

Powered by Google App Engine
This is Rietveld 408576698