Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/ui/omnibox/omnibox_controller_unittest.cc

Issue 1191373002: Componentize AutocompleteController and its supporting cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prep_builtin_provider_for_c14n
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 #include "chrome/browser/autocomplete/autocomplete_controller.h"
7 #include "chrome/browser/ui/omnibox/omnibox_controller.h" 6 #include "chrome/browser/ui/omnibox/omnibox_controller.h"
8 #include "chrome/test/base/testing_profile.h" 7 #include "chrome/test/base/testing_profile.h"
8 #include "components/omnibox/autocomplete_controller.h"
9 #include "components/omnibox/autocomplete_provider.h" 9 #include "components/omnibox/autocomplete_provider.h"
10 #include "content/public/test/test_browser_thread_bundle.h" 10 #include "content/public/test/test_browser_thread_bundle.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 class OmniboxControllerTest : public testing::Test { 13 class OmniboxControllerTest : public testing::Test {
14 protected: 14 protected:
15 OmniboxControllerTest(); 15 OmniboxControllerTest();
16 ~OmniboxControllerTest() override; 16 ~OmniboxControllerTest() override;
17 17
18 void CreateController(); 18 void CreateController();
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 // Ensure we have at least one provider. 71 // Ensure we have at least one provider.
72 ASSERT_NE(0, observed_providers); 72 ASSERT_NE(0, observed_providers);
73 73
74 // Ensure instant extended includes all the provides in classic Chrome. 74 // Ensure instant extended includes all the provides in classic Chrome.
75 int providers_with_instant_extended = observed_providers; 75 int providers_with_instant_extended = observed_providers;
76 // TODO(beaudoin): remove TYPE_SEARCH once it's no longer needed to pass 76 // TODO(beaudoin): remove TYPE_SEARCH once it's no longer needed to pass
77 // the Instant suggestion through via FinalizeInstantQuery. 77 // the Instant suggestion through via FinalizeInstantQuery.
78 CreateController(); 78 CreateController();
79 AssertProviders(providers_with_instant_extended); 79 AssertProviders(providers_with_instant_extended);
80 } 80 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_controller.cc ('k') | chrome/browser/ui/omnibox/omnibox_edit_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698