Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1188993003: Use semantic names for callbacks instead of onGestureTap (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use semantic names for callbacks instead of onGestureTap Buttons and menu items use onPressed. Also, don't pass along the sky.Event because that's a lower-level concept. I've also reordered parameter lists to put the |child| argument last in a number of places. Also, fixed a bug where FloatingActionButton was missing syncFields. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a4b84708d4d5e47094c06551fa14be7a214da58b

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -49 lines) Patch
M sky/examples/stocks2/lib/stock_home.dart View 7 chunks +11 lines, -11 lines 0 comments Download
M sky/examples/stocks2/lib/stock_settings.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +29 lines, -10 lines 4 comments Download
M sky/sdk/lib/widgets/icon_button.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 chunk +16 lines, -13 lines 0 comments Download
M sky/sdk/lib/widgets/modal_overlay.dart View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-17 22:54:43 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1188993003/diff/1/sky/sdk/lib/widgets/floating_action_button.dart File sky/sdk/lib/widgets/floating_action_button.dart (right): https://codereview.chromium.org/1188993003/diff/1/sky/sdk/lib/widgets/floating_action_button.dart#newcode21 sky/sdk/lib/widgets/floating_action_button.dart:21: this.enabled: true, either remove this or make it ...
5 years, 6 months ago (2015-06-17 22:59:22 UTC) #2
abarth-chromium
https://codereview.chromium.org/1188993003/diff/1/sky/sdk/lib/widgets/floating_action_button.dart File sky/sdk/lib/widgets/floating_action_button.dart (right): https://codereview.chromium.org/1188993003/diff/1/sky/sdk/lib/widgets/floating_action_button.dart#newcode21 sky/sdk/lib/widgets/floating_action_button.dart:21: this.enabled: true, On 2015/06/17 at 22:59:21, Hixie wrote: > ...
5 years, 6 months ago (2015-06-17 23:04:05 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-17 23:04:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4b84708d4d5e47094c06551fa14be7a214da58b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698