Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: sky/sdk/lib/widgets/modal_overlay.dart

Issue 1188993003: Use semantic names for callbacks instead of onGestureTap (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'basic.dart'; 5 import 'basic.dart';
6 import 'widget.dart'; 6 import 'widget.dart';
7 7
8 class ModalOverlay extends Component { 8 class ModalOverlay extends Component {
9 9
10 ModalOverlay({ String key, this.children, this.onDismiss }) : super(key: key); 10 ModalOverlay({ String key, this.children, this.onDismiss }) : super(key: key);
11 11
12 // static final Style _style = new Style('''
13 // position: absolute;
14 // top: 0;
15 // left: 0;
16 // bottom: 0;
17 // right: 0;''');
18
19 final List<Widget> children; 12 final List<Widget> children;
20 final GestureEventListener onDismiss; 13 final Function onDismiss;
21 14
22 Widget build() { 15 Widget build() {
23 return new Listener( 16 return new Listener(
24 child: new Stack(children), 17 onGestureTap: (_) {
25 onGestureTap: onDismiss); 18 if (onDismiss != null)
19 onDismiss();
20 },
21 child: new Stack(children)
22 );
26 } 23 }
27 24
28 } 25 }
OLDNEW
« sky/sdk/lib/widgets/floating_action_button.dart ('K') | « sky/sdk/lib/widgets/menu_item.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698