Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: sky/sdk/lib/widgets/icon_button.dart

Issue 1188993003: Use semantic names for callbacks instead of onGestureTap (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../rendering/box.dart'; 5 import '../rendering/box.dart';
6 import 'basic.dart'; 6 import 'basic.dart';
7 import 'icon.dart'; 7 import 'icon.dart';
8 import 'widget.dart'; 8 import 'widget.dart';
9 9
10 class IconButton extends Component { 10 class IconButton extends Component {
11 11
12 IconButton({ String icon: '', this.onGestureTap }) 12 IconButton({ String icon: '', this.onPressed })
13 : super(key: icon), icon = icon; 13 : super(key: icon), icon = icon;
14 14
15 final String icon; 15 final String icon;
16 final GestureEventListener onGestureTap; 16 final Function onPressed;
17 17
18 Widget build() { 18 Widget build() {
19 return new Listener( 19 return new Listener(
20 child: new Padding( 20 child: new Padding(
21 child: new Icon(type: icon, size: 24), 21 child: new Icon(type: icon, size: 24),
22 padding: const EdgeDims.all(8.0)), 22 padding: const EdgeDims.all(8.0)),
23 onGestureTap: onGestureTap); 23 onGestureTap: (_) {
24 if (onPressed != null)
25 onPressed();
26 }
27 );
24 } 28 }
25 29
26 } 30 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698