Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: sky/examples/stocks2/lib/stock_home.dart

Issue 1188993003: Use semantic names for callbacks instead of onGestureTap (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/examples/stocks2/lib/stock_home.dart
diff --git a/sky/examples/stocks2/lib/stock_home.dart b/sky/examples/stocks2/lib/stock_home.dart
index e7b58d979a9c7a3960e2882cc333a3fdd99cdf42..0e0b3b098e4c442d23ac0e7c54d100a0e93e8f68 100644
--- a/sky/examples/stocks2/lib/stock_home.dart
+++ b/sky/examples/stocks2/lib/stock_home.dart
@@ -46,13 +46,13 @@ class StockHome extends Component {
bool _isSearching = false;
String _searchQuery;
- void _handleSearchBegin(_) {
+ void _handleSearchBegin() {
setState(() {
_isSearching = true;
});
}
- void _handleSearchEnd(_) {
+ void _handleSearchEnd() {
setState(() {
_isSearching = false;
_searchQuery = null;
@@ -76,14 +76,14 @@ class StockHome extends Component {
PopupMenuController _menuController;
- void _handleMenuShow(_) {
+ void _handleMenuShow() {
setState(() {
_menuController = new PopupMenuController();
_menuController.open();
});
}
- void _handleMenuHide(_) {
+ void _handleMenuHide() {
setState(() {
_menuController.close().then((_) {
setState(() {
@@ -125,7 +125,7 @@ class StockHome extends Component {
new MenuItem(
key: 'Optimistic Menu Item',
icon: 'action/thumb_up',
- onGestureTap: (event) => _handleStockModeChange(StockMode.optimistic),
+ onPressed: () => _handleStockModeChange(StockMode.optimistic),
children: [
new Flexible(child: new Text('Optimistic')),
new Radio(key: 'optimistic-radio', value: StockMode.optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
@@ -133,7 +133,7 @@ class StockHome extends Component {
new MenuItem(
key: 'Pessimistic Menu Item',
icon: 'action/thumb_down',
- onGestureTap: (event) => _handleStockModeChange(StockMode.pessimistic),
+ onPressed: () => _handleStockModeChange(StockMode.pessimistic),
children: [
new Flexible(child: new Text('Pessimistic')),
new Radio(key: 'pessimistic-radio', value: StockMode.pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
@@ -142,7 +142,7 @@ class StockHome extends Component {
new MenuItem(
key: 'Settings',
icon: 'action/settings',
- onGestureTap: (event) => _navigator.pushNamed('/settings'),
+ onPressed: () => _navigator.pushNamed('/settings'),
children: [new Text('Settings')]),
new MenuItem(
key: 'Help & Feedback',
@@ -156,15 +156,15 @@ class StockHome extends Component {
return new ToolBar(
left: new IconButton(
icon: 'navigation/menu_white',
- onGestureTap: (_) => _drawerController.toggle()),
+ onPressed: _drawerController.toggle),
center: new Text('Stocks', style: typography.white.title),
right: [
new IconButton(
icon: 'action/search_white',
- onGestureTap: _handleSearchBegin),
+ onPressed: _handleSearchBegin),
new IconButton(
icon: 'navigation/more_vert_white',
- onGestureTap: _handleMenuShow)
+ onPressed: _handleMenuShow)
],
backgroundColor: colors.Purple[500]
);
@@ -175,7 +175,7 @@ class StockHome extends Component {
return new ToolBar(
left: new IconButton(
icon: 'navigation/arrow_back_grey600',
- onGestureTap: _handleSearchEnd),
+ onPressed: _handleSearchEnd),
center: new Input(
focused: true,
placeholder: 'Search stocks',
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_settings.dart » ('j') | sky/sdk/lib/widgets/floating_action_button.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698