Click event should be fired before change events for checkbox and radio button.

Click event should be fired before change events for checkbox and radio button.

This cl fixes this issue.

Bug=178505
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197239

[Paritosh Kumar, 2015-06-16 08:02:40]

paritosh.in@samsung.com changed reviewers:
+ tkent@chromium.org

[Paritosh Kumar, 2015-06-16 08:02:40]

@tkent: Please have a look. The cause of that regression was call of
setTextAsOfLastFormControlChangeEvent(String()) in
dispatchChangeEventIfNeeded().

[tkent, 2015-06-16 08:10:05]

Please add a test for crbug.com/500084.

[Paritosh Kumar, 2015-06-16 09:02:04]

On 2015/06/16 08:10:05, tkent wrote:
> Please add a test for crbug.com/500084.

Updated the cl with test of crbug.com/500084, as added tests for two consecutive
click and space key down on checkbox and radio buuton.

Please take a look.

[tkent, 2015-06-16 23:56:29]

lgtm

https://codereview.chromium.org/1188763002/diff/20001/LayoutTests/fast/forms/...
File LayoutTests/fast/forms/radio-checkbox-events-order.html (right):

https://codereview.chromium.org/1188763002/diff/20001/LayoutTests/fast/forms/...
LayoutTests/fast/forms/radio-checkbox-events-order.html:72: checkbox1.focus();
This line is confusing.  I think this line should be removed or this should be
radio1.focus().

[Paritosh Kumar, 2015-06-17 06:01:33]

Thanks tkent
removed that line.

https://codereview.chromium.org/1188763002/diff/20001/LayoutTests/fast/forms/...
File LayoutTests/fast/forms/radio-checkbox-events-order.html (right):

https://codereview.chromium.org/1188763002/diff/20001/LayoutTests/fast/forms/...
LayoutTests/fast/forms/radio-checkbox-events-order.html:72: checkbox1.focus();
On 2015/06/16 23:56:29, tkent wrote:
> This line is confusing.  I think this line should be removed or this should be
> radio1.focus().

Removed. Thanks.

[Paritosh Kumar, 2015-06-17 06:01:51]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[Paritosh Kumar, 2015-06-17 06:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1188763002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-17 06:02:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1188763002/40001

[commit-bot: I haz the power, 2015-06-17 07:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 07:03:22]

Dry run: This issue passed the CQ dry run.

[Paritosh Kumar, 2015-06-17 07:05:27]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2015-06-17 07:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1188763002/40001

[commit-bot: I haz the power, 2015-06-17 07:10:22]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197239