Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/html/forms/CheckboxInputType.cpp

Issue 1188763002: Click event should be fired before change events for checkbox and radio button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/RadioInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 element().setChecked(!state->checked, DispatchChangeEvent); 84 element().setChecked(!state->checked, DispatchChangeEvent);
85 85
86 return state.release(); 86 return state.release();
87 } 87 }
88 88
89 void CheckboxInputType::didDispatchClick(Event* event, const ClickHandlingState& state) 89 void CheckboxInputType::didDispatchClick(Event* event, const ClickHandlingState& state)
90 { 90 {
91 if (event->defaultPrevented() || event->defaultHandled()) { 91 if (event->defaultPrevented() || event->defaultHandled()) {
92 element().setIndeterminate(state.indeterminate); 92 element().setIndeterminate(state.indeterminate);
93 element().setChecked(state.checked); 93 element().setChecked(state.checked);
94 } else {
95 element().dispatchChangeEventIfNeeded();
94 } 96 }
95 97
96 // The work we did in willDispatchClick was default handling. 98 // The work we did in willDispatchClick was default handling.
97 event->setDefaultHandled(); 99 event->setDefaultHandled();
98 } 100 }
99 101
100 bool CheckboxInputType::shouldAppearIndeterminate() const 102 bool CheckboxInputType::shouldAppearIndeterminate() const
101 { 103 {
102 return element().indeterminate(); 104 return element().indeterminate();
103 } 105 }
104 106
105 } // namespace blink 107 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/RadioInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698