Chromium Code Reviews Chromium Code Reviews
Issue 1188763002:
Click event should be fired before change events for checkbox and radio button. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE HTML> | |
| 2 | |
| 3 <script src="../../resources/js-test.js"></script> | |
| 4 | |
| 5 <body> | |
| 6 <input type="checkbox" id="checkbox-btn1" onclick="doClickAction(event)" onchang e="doChangeAction(event)"/> | |
| 7 <input type="checkbox" id="checkbox-btn2" onclick="doClickAction(event); event.p reventDefault()" onchange="doChangeAction(event)"/> | |
| 8 <input type="radio" id="radio-btn1" onclick="doClickAction(event)" onchange="doC hangeAction(event)"/> | |
| 9 <input type="radio" id="radio-btn2" onclick="doClickAction(event); event.prevent Default()" onchange="doChangeAction(event)"/> | |
| 10 <script> | |
| 11 description('Tests the order of onclick and onchange'); | |
| 12 var message = ''; | |
| 13 | |
| 14 function doClickAction(e) | |
| 15 { | |
| 16 shouldBeEqualToString('message', ''); | |
| 17 message = 'clicked'; | |
| 18 } | |
| 19 | |
| 20 function doChangeAction(e) | |
| 21 { | |
| 22 shouldBeEqualToString('message', 'clicked'); | |
| 23 message = 'changed'; | |
| 24 } | |
| 25 | |
| 26 var checkbox1 = document.getElementById('checkbox-btn1'); | |
| 27 var checkbox2 = document.getElementById('checkbox-btn2'); | |
| 28 var radio1 = document.getElementById('radio-btn1'); | |
| 29 var radio2 = document.getElementById('radio-btn2'); | |
| 30 | |
| 31 message = ''; | |
| 32 checkbox1.click(); | |
| 33 shouldBeEqualToString('message', 'changed'); | |
| 34 shouldBeTrue('checkbox1.checked'); | |
| 35 | |
| 36 message = ''; | |
| 37 checkbox1.click(); | |
| 38 shouldBeEqualToString('message', 'changed'); | |
| 39 shouldBeFalse('checkbox1.checked'); | |
| 40 | |
| 41 message = ''; | |
| 42 checkbox2.click(); | |
| 43 shouldBeEqualToString('message', 'clicked'); | |
| 44 shouldBeFalse('checkbox2.checked'); | |
| 45 | |
| 46 message = ''; | |
| 47 checkbox1.checked = false; | |
| 48 checkbox1.focus(); | |
| 49 eventSender.keyDown(' '); | |
| 50 shouldBeEqualToString('message', 'changed'); | |
| 51 shouldBeTrue('checkbox1.checked'); | |
| 52 | |
| 53 message = ''; | |
| 54 checkbox1.focus(); | |
| 55 eventSender.keyDown(' '); | |
| 56 shouldBeEqualToString('message', 'changed'); | |
| 57 shouldBeFalse('checkbox1.checked'); | |
| 58 | |
| 59 message = ''; | |
| 60 checkbox2.checked = false; | |
| 61 checkbox2.focus(); | |
| 62 eventSender.keyDown(' '); | |
| 63 shouldBeEqualToString('message', 'clicked'); | |
| 64 shouldBeFalse('checkbox2.checked'); | |
| 65 | |
| 66 message = ''; | |
| 67 radio1.click(); | |
| 68 shouldBeEqualToString('message', 'changed'); | |
| 69 shouldBeTrue('radio1.checked'); | |
| 70 | |
| 71 message = ''; | |
| 72 checkbox1.focus(); | |
|
tkent
2015/06/16 23:56:29
This line is confusing. I think this line should
Paritosh Kumar
2015/06/17 06:01:33
Removed. Thanks.
| |
| 73 radio1.click(); | |
| 74 shouldBeEqualToString('message', 'clicked'); | |
| 75 shouldBeTrue('radio1.checked'); | |
| 76 | |
| 77 message = ''; | |
| 78 radio2.click(); | |
| 79 shouldBeEqualToString('message', 'clicked'); | |
| 80 shouldBeFalse('radio2.checked'); | |
| 81 | |
| 82 message = ''; | |
| 83 radio1.checked = false; | |
| 84 radio1.focus(); | |
| 85 eventSender.keyDown(' '); | |
| 86 shouldBeEqualToString('message', 'changed'); | |
| 87 shouldBeTrue('radio1.checked'); | |
| 88 | |
| 89 message = ''; | |
| 90 radio1.focus(); | |
| 91 eventSender.keyDown(' '); | |
| 92 shouldBeEqualToString('message', ''); | |
| 93 shouldBeTrue('radio1.checked'); | |
| 94 | |
| 95 message = ''; | |
| 96 radio2.checked = false; | |
| 97 radio2.focus(); | |
| 98 eventSender.keyDown(' '); | |
| 99 shouldBeEqualToString('message', 'clicked'); | |
| 100 shouldBeFalse('radio2.checked'); | |
| 101 | |
| 102 </script> | |
| 103 </body> | |
| OLD | NEW |
