Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 1188763002: Click event should be fired before change events for checkbox and radio button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // Returns true if the type is button, reset, or submit. 89 // Returns true if the type is button, reset, or submit.
90 bool isTextButton() const; 90 bool isTextButton() const;
91 // Returns true if the type is email, number, password, search, tel, text, 91 // Returns true if the type is email, number, password, search, tel, text,
92 // or url. 92 // or url.
93 bool isTextField() const; 93 bool isTextField() const;
94 94
95 bool isImage() const; 95 bool isImage() const;
96 96
97 bool checked() const { return m_isChecked; } 97 bool checked() const { return m_isChecked; }
98 void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent); 98 void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent);
99 void dispatchChangeEventIfNeeded();
99 100
100 // 'indeterminate' is a state independent of the checked state that causes t he control to draw in a way that hides the actual state. 101 // 'indeterminate' is a state independent of the checked state that causes t he control to draw in a way that hides the actual state.
101 bool indeterminate() const { return m_isIndeterminate; } 102 bool indeterminate() const { return m_isIndeterminate; }
102 void setIndeterminate(bool); 103 void setIndeterminate(bool);
103 // shouldAppearChecked is used by the layout tree/CSS while checked() is use d by JS to determine checked state 104 // shouldAppearChecked is used by the layout tree/CSS while checked() is use d by JS to determine checked state
104 bool shouldAppearChecked() const; 105 bool shouldAppearChecked() const;
105 virtual bool shouldAppearIndeterminate() const override; 106 virtual bool shouldAppearIndeterminate() const override;
106 107
107 int size() const; 108 int size() const;
108 bool sizeShouldIncludeDecoration(int& preferredSize) const; 109 bool sizeShouldIncludeDecoration(int& preferredSize) const;
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 // The ImageLoader must be owned by this element because the loader code ass umes 389 // The ImageLoader must be owned by this element because the loader code ass umes
389 // that it lives as long as its owning element lives. If we move the loader into 390 // that it lives as long as its owning element lives. If we move the loader into
390 // the ImageInput object we may delete the loader while this element lives o n. 391 // the ImageInput object we may delete the loader while this element lives o n.
391 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader; 392 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
392 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r; 393 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r;
393 }; 394 };
394 395
395 } // namespace blink 396 } // namespace blink
396 397
397 #endif // HTMLInputElement_h 398 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698