Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot(). (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Rename insert() to insertChildRoot() so it's consistent with detachChildRoot(). TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/cf4a301c7c048d183e5129a68dfa31417eec3372

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	sky/sdk/lib/widgets/basic.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/widgets/scaffold.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

Hixie

5 years, 6 months ago (2015-06-17 23:00:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cf4a301c7c048d183e5129a68dfa31417eec3372 (presubmit successful).