Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: sky/sdk/lib/widgets/basic.dart

Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/scaffold.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/basic.dart
diff --git a/sky/sdk/lib/widgets/basic.dart b/sky/sdk/lib/widgets/basic.dart
index 02620d86c5ebabdd28bfd3e7bc6191cdaa3ff53a..2f221b7688b8d1d7b95078118f658fb1cd79f0df 100644
--- a/sky/sdk/lib/widgets/basic.dart
+++ b/sky/sdk/lib/widgets/basic.dart
@@ -359,7 +359,7 @@ class Inline extends RenderObjectWrapper {
root.inline = text;
}
- void insert(RenderObjectWrapper child, dynamic slot) {
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
assert(false);
// Inline does not support having children currently
}
@@ -398,7 +398,7 @@ class Image extends RenderObjectWrapper {
root.requestedSize = size;
}
- void insert(RenderObjectWrapper child, dynamic slot) {
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
assert(false);
// Image does not support having children currently
}
@@ -424,7 +424,7 @@ class WidgetToRenderBoxAdapter extends RenderObjectWrapper {
}
}
- void insert(RenderObjectWrapper child, dynamic slot) {
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
assert(false);
// WidgetToRenderBoxAdapter cannot have Widget children; by
// definition, it is the transition out of the Widget world.
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/scaffold.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698