sky/sdk/lib/widgets/scaffold.dart - Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/scaffold.dart

Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot(). (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/widgets/scaffold.dart

diff --git a/sky/sdk/lib/widgets/scaffold.dart b/sky/sdk/lib/widgets/scaffold.dart

index b9b5e508e8415525a7a9b721b573b94ea34610b0..fcf7d6de3821b91334de47017b94fbd1106d79ce 100644

--- a/sky/sdk/lib/widgets/scaffold.dart

+++ b/sky/sdk/lib/widgets/scaffold.dart

@@ -181,7 +181,7 @@ class Scaffold extends RenderObjectWrapper {

RenderScaffold get root => super.root;

RenderScaffold createNode() => new RenderScaffold();

- void insert(RenderObjectWrapper child, ScaffoldSlots slot) {

+ void insertChildRoot(RenderObjectWrapper child, ScaffoldSlots slot) {

root[slot] = child != null ? child.root : null;

}

« no previous file with comments | « sky/sdk/lib/widgets/basic.dart ('k') | sky/sdk/lib/widgets/widget.dart » ('j') | no next file with comments »