Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: sky/sdk/lib/widgets/widget.dart

Issue 1187023005: Rename insert() to insertChildRoot() so it's consistent with detachChildRoot(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/scaffold.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/widget.dart
diff --git a/sky/sdk/lib/widgets/widget.dart b/sky/sdk/lib/widgets/widget.dart
index 2235180834d9c32a458a81e46d1b6af230775464..4df951b06f07a6e560912ed2f37118373ff0ed2e 100644
--- a/sky/sdk/lib/widgets/widget.dart
+++ b/sky/sdk/lib/widgets/widget.dart
@@ -491,7 +491,7 @@ abstract class RenderObjectWrapper extends Widget {
static RenderObjectWrapper _getMounted(RenderObject node) => _nodeMap[node];
RenderObjectWrapper _ancestor;
- void insert(RenderObjectWrapper child, dynamic slot);
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot);
void detachChildRoot(RenderObjectWrapper child);
void _sync(Widget old, dynamic slot) {
@@ -503,7 +503,7 @@ abstract class RenderObjectWrapper extends Widget {
_root = createNode();
_ancestor = findAncestor(RenderObjectWrapper);
if (_ancestor is RenderObjectWrapper)
- _ancestor.insert(this, slot);
+ _ancestor.insertChildRoot(this, slot);
} else {
_root = old.root;
_ancestor = old._ancestor;
@@ -563,7 +563,7 @@ abstract class OneChildRenderObjectWrapper extends RenderObjectWrapper {
_child = syncChild(child, oldChild, null);
}
- void insert(RenderObjectWrapper child, dynamic slot) {
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is RenderObjectWithChildMixin);
assert(slot == null);
@@ -600,7 +600,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
final List<Widget> children;
- void insert(RenderObjectWrapper child, dynamic slot) {
+ void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer
assert(slot == null || slot is RenderObject);
assert(root is ContainerRenderObjectMixin);
« no previous file with comments | « sky/sdk/lib/widgets/scaffold.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698