Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1186743002: Build: Don't pass /GL to Clang on Windows (Closed)

Created:
5 years, 6 months ago by hans
Modified:
5 years, 6 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build: Don't pass /GL to Clang on Windows Windows Clang's support for LTO isn't ready to take on Chrome yet. BUG=82385 R=thakis@chromium.org TBR=scottmg Committed: https://chromium.googlesource.com/chromium/src/+/4e76e7926ee51bdfdd635437920f455ae6444912

Patch Set 1 #

Patch Set 2 : Drop newline #

Patch Set 3 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M build/common.gypi View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hans
This should fix http://build.chromium.org/p/chromium.fyi/builders/CrWinClang Please take a look.
5 years, 6 months ago (2015-06-13 01:08:49 UTC) #2
Nico
lgtm to get the build green, but /GL shouldn't enable -flto as it's always going ...
5 years, 6 months ago (2015-06-13 01:54:34 UTC) #3
Nico
(I left a comment on the r239213 clang commit)
5 years, 6 months ago (2015-06-13 02:00:59 UTC) #4
hans
On 2015/06/13 01:54:34, Nico (afk vacation Fri Jun 12) wrote: > lgtm to get the ...
5 years, 6 months ago (2015-06-13 03:04:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186743002/40001
5 years, 6 months ago (2015-06-13 03:05:47 UTC) #8
hans
Committed patchset #3 (id:40001) manually as 4e76e7926ee51bdfdd635437920f455ae6444912 (presubmit successful).
5 years, 6 months ago (2015-06-13 03:35:52 UTC) #9
Nico
5 years, 6 months ago (2015-06-15 18:24:30 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1185133004/ by thakis@chromium.org.

The reason for reverting is: Broke some official builds
(http://crbug.com/500393). Will roll clang forward instead..

Powered by Google App Engine
This is Rietveld 408576698