Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: build/common.gypi

Issue 1186743002: Build: Don't pass /GL to Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5487 matching lines...) Expand 10 before | Expand all | Expand 10 after
5498 'msvs_settings': { 5498 'msvs_settings': {
5499 'VCCLCompilerTool': { 5499 'VCCLCompilerTool': {
5500 # 2, optimizeMaxSpeed, Maximize Speed (/O2) 5500 # 2, optimizeMaxSpeed, Maximize Speed (/O2)
5501 'Optimization': '2', 5501 'Optimization': '2',
5502 # 1, favorSpeed - Favor fast code (/Ot) 5502 # 1, favorSpeed - Favor fast code (/Ot)
5503 'FavorSizeOrSpeed': '1', 5503 'FavorSizeOrSpeed': '1',
5504 }, 5504 },
5505 }, 5505 },
5506 }, 5506 },
5507 ], 5507 ],
5508 ['optimize=="max"', { 5508 ['optimize=="max" and clang==1', {
5509 # Like "max" below, but without WholeProgramOptimization.
5510 # TODO(hans): Remove when Clang rolls past r239656.
5511 'msvs_settings': {
5512 'VCCLCompilerTool': {
5513 'Optimization': '2',
5514 'FavorSizeOrSpeed': '1',
5515 },
5516 },
5517 },
5518 ],
5519 ['optimize=="max" and clang==0', {
5509 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO 5520 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
5510 # builds. Probably anything that this would catch that 5521 # builds. Probably anything that this would catch that
5511 # wouldn't be caught in a normal build isn't going to 5522 # wouldn't be caught in a normal build isn't going to
5512 # actually be a bug, so the incremental value of C4702 for 5523 # actually be a bug, so the incremental value of C4702 for
5513 # PGO builds is likely very small. 5524 # PGO builds is likely very small.
5514 'msvs_disabled_warnings': [ 5525 'msvs_disabled_warnings': [
5515 4702 5526 4702
5516 ], 5527 ],
5517 'msvs_settings': { 5528 'msvs_settings': {
5518 'VCCLCompilerTool': { 5529 'VCCLCompilerTool': {
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
6192 # settings in target dicts. SYMROOT is a special case, because many other 6203 # settings in target dicts. SYMROOT is a special case, because many other
6193 # Xcode variables depend on it, including variables such as 6204 # Xcode variables depend on it, including variables such as
6194 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6205 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6195 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6206 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6196 # files to appear (when present) in the UI as actual files and not red 6207 # files to appear (when present) in the UI as actual files and not red
6197 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6208 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6198 # and therefore SYMROOT, needs to be set at the project level. 6209 # and therefore SYMROOT, needs to be set at the project level.
6199 'SYMROOT': '<(DEPTH)/xcodebuild', 6210 'SYMROOT': '<(DEPTH)/xcodebuild',
6200 }, 6211 },
6201 } 6212 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698