Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 1186743002: Build: Don't pass /GL to Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5e41fce43d127a090ac9faefe55cafd8403cd818..9399c5d17afc3e1653eb003a77500c67e06ea284 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5505,7 +5505,18 @@
},
},
],
- ['optimize=="max"', {
+ ['optimize=="max" and clang==1', {
+ # Like "max" below, but without WholeProgramOptimization.
+ # TODO(hans): Remove when Clang rolls past r239656.
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'Optimization': '2',
+ 'FavorSizeOrSpeed': '1',
+ },
+ },
+ },
+ ],
+ ['optimize=="max" and clang==0', {
# Disable Warning 4702 ("Unreachable code") for the WPO/PGO
# builds. Probably anything that this would catch that
# wouldn't be caught in a normal build isn't going to
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698