Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1186743002: Build: Don't pass /GL to Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 1189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1200 1200
1201 # Turns up the optimization level. On Windows, this implies whole program 1201 # Turns up the optimization level. On Windows, this implies whole program
1202 # optimization and link-time code generation which is very expensive and should 1202 # optimization and link-time code generation which is very expensive and should
1203 # be used sparingly. 1203 # be used sparingly.
1204 config("optimize_max") { 1204 config("optimize_max") {
1205 cflags = common_optimize_on_cflags 1205 cflags = common_optimize_on_cflags
1206 ldflags = common_optimize_on_ldflags 1206 ldflags = common_optimize_on_ldflags
1207 if (is_win) { 1207 if (is_win) {
1208 cflags -= [ "/Os" ] 1208 cflags -= [ "/Os" ]
1209 cflags += [ "/Ot" ] # Favor speed over size. 1209 cflags += [ "/Ot" ] # Favor speed over size.
1210 if (is_official_build) { 1210 if (is_official_build && !is_clang) {
1211 # TODO(GYP): TODO(dpranke): Should these only be on in an official 1211 # TODO(GYP): TODO(dpranke): Should these only be on in an official
1212 # build, or on all the time? For now we'll require official build so 1212 # build, or on all the time? For now we'll require official build so
1213 # that the compile is clean. 1213 # that the compile is clean.
1214 # TODO(hans): Remove Clang special-case when it rolls past r239656.
1214 cflags += [ 1215 cflags += [
1215 "/GL", # Whole program optimization. 1216 "/GL", # Whole program optimization.
1216 1217
1217 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO builds. 1218 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO builds.
1218 # Probably anything that this would catch that wouldn't be caught in a 1219 # Probably anything that this would catch that wouldn't be caught in a
1219 # normal build isn't going to actually be a bug, so the incremental 1220 # normal build isn't going to actually be a bug, so the incremental
1220 # value of C4702 for PGO builds is likely very small. 1221 # value of C4702 for PGO builds is likely very small.
1221 "/wd4702", 1222 "/wd4702",
1222 ] 1223 ]
1223 ldflags += [ "/LTCG" ] 1224 ldflags += [ "/LTCG" ]
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 cflags += [ "-gsplit-dwarf" ] 1257 cflags += [ "-gsplit-dwarf" ]
1257 } 1258 }
1258 } 1259 }
1259 } 1260 }
1260 1261
1261 config("no_symbols") { 1262 config("no_symbols") {
1262 if (!is_win) { 1263 if (!is_win) {
1263 cflags = [ "-g0" ] 1264 cflags = [ "-g0" ]
1264 } 1265 }
1265 } 1266 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698