Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed)

Created:
5 years, 6 months ago by ulan

Modified:
5 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove the --collect-maps flag. Maps should be always collected. Reasons: - It is not used. - It complicates code in GC. BUG=chromium:499713 LOG=NO Committed: https://crrev.com/3938956bdc34b75b6478fa7afd0cae68bedff291 Cr-Commit-Position: refs/heads/master@{#29027}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -9 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/mark-compact.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/heap/objects-visiting-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184723002/1

5 years, 6 months ago (2015-06-15 11:59:15 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-15 12:28:54 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3938956bdc34b75b6478fa7afd0cae68bedff291
Cr-Commit-Position: refs/heads/master@{#29027}