src/objects-inl.h - Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 27528d644253793d8418fc019ec183557cd52c31..18c0a68b673370780782215523ca5240049ff22c 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -4867,7 +4867,6 @@ Object* Code::GetObjectFromEntryAddress(Address location_of_address) {

bool Code::IsWeakObjectInOptimizedCode(Object* object) {

- if (!FLAG_collect_maps) return false;

if (object->IsMap()) {

return Map::cast(object)->CanTransition() &&

FLAG_weak_embedded_maps_in_optimized_code;

« no previous file with comments | « src/heap/objects-visiting-inl.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »