Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: src/objects-inl.h

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/objects-visiting-inl.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 4849 matching lines...) Expand 10 before | Expand all | Expand 10 after
4860 } 4860 }
4861 4861
4862 4862
4863 Object* Code::GetObjectFromEntryAddress(Address location_of_address) { 4863 Object* Code::GetObjectFromEntryAddress(Address location_of_address) {
4864 return HeapObject:: 4864 return HeapObject::
4865 FromAddress(Memory::Address_at(location_of_address) - Code::kHeaderSize); 4865 FromAddress(Memory::Address_at(location_of_address) - Code::kHeaderSize);
4866 } 4866 }
4867 4867
4868 4868
4869 bool Code::IsWeakObjectInOptimizedCode(Object* object) { 4869 bool Code::IsWeakObjectInOptimizedCode(Object* object) {
4870 if (!FLAG_collect_maps) return false;
4871 if (object->IsMap()) { 4870 if (object->IsMap()) {
4872 return Map::cast(object)->CanTransition() && 4871 return Map::cast(object)->CanTransition() &&
4873 FLAG_weak_embedded_maps_in_optimized_code; 4872 FLAG_weak_embedded_maps_in_optimized_code;
4874 } 4873 }
4875 if (object->IsCell()) { 4874 if (object->IsCell()) {
4876 object = Cell::cast(object)->value(); 4875 object = Cell::cast(object)->value();
4877 } else if (object->IsPropertyCell()) { 4876 } else if (object->IsPropertyCell()) {
4878 object = PropertyCell::cast(object)->value(); 4877 object = PropertyCell::cast(object)->value();
4879 } 4878 }
4880 if (object->IsJSObject()) { 4879 if (object->IsJSObject()) {
(...skipping 2466 matching lines...) Expand 10 before | Expand all | Expand 10 after
7347 #undef READ_SHORT_FIELD 7346 #undef READ_SHORT_FIELD
7348 #undef WRITE_SHORT_FIELD 7347 #undef WRITE_SHORT_FIELD
7349 #undef READ_BYTE_FIELD 7348 #undef READ_BYTE_FIELD
7350 #undef WRITE_BYTE_FIELD 7349 #undef WRITE_BYTE_FIELD
7351 #undef NOBARRIER_READ_BYTE_FIELD 7350 #undef NOBARRIER_READ_BYTE_FIELD
7352 #undef NOBARRIER_WRITE_BYTE_FIELD 7351 #undef NOBARRIER_WRITE_BYTE_FIELD
7353 7352
7354 } } // namespace v8::internal 7353 } } // namespace v8::internal
7355 7354
7356 #endif // V8_OBJECTS_INL_H_ 7355 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/heap/objects-visiting-inl.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698