src/heap/objects-visiting-inl.h - Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/objects-visiting-inl.h

diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h

index 7f83f483ba750e9e149da2c8ed580f5f6fe0dee0..4a485b16b76c58fbc75f8036b8a83a9ed06fa878 100644

--- a/src/heap/objects-visiting-inl.h

+++ b/src/heap/objects-visiting-inl.h

@@ -298,7 +298,7 @@ void StaticMarkingVisitor<StaticVisitor>::VisitMap(Map* map,

// When map collection is enabled we have to mark through map's transitions

// and back pointers in a special way to make these links weak.

- if (FLAG_collect_maps && map_object->CanTransition()) {

+ if (map_object->CanTransition()) {

MarkMapContents(heap, map_object);

} else {

StaticVisitor::VisitPointers(

« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »