Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/IceCfg.cpp

Issue 1182603004: Subzero: Transform suitable Load/Arith/Store sequences into RMW ops. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerX8632.cpp ('k') | src/IceClFlags.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index 12de45274e441f3631f8c0467d13feeca7f59d20..2cbe571c815035b22cf054830a5c8617ed844f19 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -433,8 +433,12 @@ void Cfg::liveness(LivenessMode Mode) {
// register. This is accomplished by extending the entry
// block's instruction range from [2,n) to [1,n) which will
// transform the problematic [2,2) live ranges into [1,2).
- if (FirstInstNum == Inst::NumberInitial)
+ if (Node == getEntryNode()) {
+ // TODO(stichnot): Make it a strict requirement that the entry
+ // node gets the lowest instruction numbers, so that extending
+ // the live range for in-args is guaranteed to work.
FirstInstNum = Inst::NumberExtended;
+ }
Node->livenessAddIntervals(getLiveness(), FirstInstNum, LastInstNum);
}
}
« no previous file with comments | « src/IceAssemblerX8632.cpp ('k') | src/IceClFlags.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698