Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182183003: Move EndsWith to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
jschuh
CC:
chromium-reviews, skanuj+watch_chromium.org, oshima+watch_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, maxbogue+watch_chromium.org, yzshen+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, Aaron Boodman, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, derat+watch_chromium.org, tapted, qsr+mojo_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, asvitkine+watch_chromium.org, estade+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, pfeldman, Jered, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina, donnd+watch_chromium.org, nektar+watch_chromium.org, mcasas+watch_chromium.org, yurys, plaree+watch_chromium.org, David Black, davemoore+watch_chromium.org, samarth+watch_chromium.org, wfh+watch_chromium.org, kmadhusu+watch_chromium.org, darin (slow to review), James Su, wjia+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move EndsWith to base namespace. TBR=jschuh@chromium.org Committed: https://crrev.com/17b32adf2de02e5a4cdf1c0195bb3b06c721b2ca Cr-Commit-Position: refs/heads/master@{#334284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -190 lines) Patch
M base/strings/string_util.h View 3 chunks +12 lines, -9 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/delay_load_hook_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/cld_component_installer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/default_apps.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/variations/experiment_labels.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/dom_distiller/core/page_features.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M components/google/core/browser/google_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/keyword_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/search_suggestion_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/search/search.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/net/variations_http_header_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/android_granularity_movement_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/set_process_title.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/user_script.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/server/http_server_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/flip_server/mem_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_stream_cookie_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/document_loader.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/font_list_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
Since we were talking about this.
5 years, 6 months ago (2015-06-12 20:13:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182183003/1
5 years, 6 months ago (2015-06-12 20:13:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182183003/1
5 years, 6 months ago (2015-06-12 22:37:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 23:47:15 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 23:48:12 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17b32adf2de02e5a4cdf1c0195bb3b06c721b2ca
Cr-Commit-Position: refs/heads/master@{#334284}

Powered by Google App Engine
This is Rietveld 408576698